Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a typo #1101

Closed
wants to merge 1 commit into from
Closed

fix a typo #1101

wants to merge 1 commit into from

Conversation

songheony
Copy link
Contributor

@songheony songheony commented Mar 9, 2020 •
edited
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes a typo in "Best Practices" section of "Trainer"
from

from argparser import AugumentParser

to

from argparse import ArgumentParser

Did you have fun?

Of course, Yes!

@songheony songheony changed the title fixes a typo fix a typo Mar 9, 2020
Borda
Borda approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Borda Borda added docs Documentation related ready PRs ready to be merged labels Mar 9, 2020
@Borda
Copy link
Member

Borda commented Mar 11, 2020

hey there, we have added GPU CI test, so could we kindly ask to rebase/merge master which will trigger these tests so we do not need to test it manually... Thx for your understanding 🤖

@songheony
Copy link
Contributor Author

I got it. then I'll close this PR and do it again.

@songheony songheony closed this Mar 12, 2020
@Borda
Copy link
Member

Borda commented Mar 12, 2020

There was no need to close it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

Assignees
No one assigned
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@songheony @Borda